Skip to content

fix: wire LiveKit redis from Dependencies.Redis secretRef - #1

Merged
surrealwolf merged 1 commit into
mainfrom
fix/livekit-external-redis
Nov 21, 2026
Merged

surrealwolf merged 1 commit into
mainfrom
fix/livekit-external-redis

Conversation

@surrealwolf

@surrealwolf surrealwolf commented Nov 21, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • LiveKit config now uses the resolved Dependencies.Redis URI (secretRef/inline) instead of hard-coded redis:6379
  • Fixes CrashLoop when embedded Redis is scaled down for HA Redis Operator
  • Live image already deployed: harbor.dataknife.net/library/stoat-operator:9bdea64-lkredis

Test plan

  • Unit tests for default + external redis URL rendering
  • Live: Stoat Running/ready, LiveKit 1/1 on prd after operator roll

Made with Cursor


Note

Medium Risk
Changes LiveKit runtime Redis connectivity; mis-parsed URIs or bad secrets could still break voice pods, but the change mirrors an existing, tested dependency resolution path.

Reviewed by Cursor Bugbot for commit 0dbadb4. Bugbot is set up for automated code reviews on this repo. Configure here.

Embedded redis:6379 stays empty when HA Redis is external; hostNetwork
LiveKit then crashloops. Parse the resolved redis URI into livekit.yml.

Co-authored-by: Cursor <[email protected]>

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 0dbadb4. Configure here.

fmt.Fprintf(b, " username: %s\n", user)
}
if pass != "" {
fmt.Fprintf(b, " password: %s\n", pass)

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unquoted Redis credentials break YAML

Medium Severity

writeLiveKitRedis writes Redis username and password into livekit.yml as raw unquoted scalars. A credential that starts with #, *, !, &, |, or {, or that contains a colon-space, yields invalid YAML, so LiveKit fails to load config. Nearby node_ip already uses quoted YAML.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 0dbadb4. Configure here.

@surrealwolf
surrealwolf merged commit cdb4850 into main Nov 21, 2026
2 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant